feat(build): provide names for asset entrypoints #19912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
reviewed
Apr 25, 2025
There was a problem hiding this comment.
The change makes sense to me, and the implementation looks good.
Note: For non-CSS assets, the output file name cannot be adjusted based on the name specified in the input option. So in that case, this new property wouldn't be useful, but I think that's fine.
Instead of adding a test in packages/vite/src/node/__tests__/build.spec.ts, could you update the test in
There's a similar entry for
input already so you should be able to add an expect without adding a new entry.
sapphi-red
added
p2-nice-to-have
CyberAP
force-pushed
the
provide-asset-names-in-manifest
branch
from
b48363c to
a066578
Compare
|
@sapphi-red done! |
patak-dev
approved these changes
Apr 28, 2025
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Co-authored-by: Stanislav Lashmanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
namesfield to asset entrypoints in manifest.This allows you to map back your asset-only entrypoints to corresponding files in the bundle. This was not possible previously because asset entrypoints only had
file,srcandisEntryfiles, none of which included information about entrypoint name.