-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix: avoid using Promise.allSettled
in preload function
#19805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Promise.allSettled
in preload function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can have this change.
We do say "Vite does not cover polyfills." here. But for code generated by Vite, I think it would be more friendly for users if it doesn't require polyfills.
https://vite.dev/guide/build.html#browser-compatibility
If we go this way, we should ensure the code generated by Vite only uses features that are supported by the minimum browser support ranges. It fully supports ES2017 and partially supports ES2018.
Thanks. @sapphi-red |
@sapphi-red Sorry to bother you. But when will this pr be merged? When will it release? |
Hey @novlan1, we don't have a definite time to merge PRs and do releases. To avoid being blocked by vite release process or any other project, you can patch the package to use the PR. See pnpm patch for example https://pnpm.io/cli/patch |
Got it! Thank you. |
Description
Add polyfill of Promise.allSettled. In some legacy browser.