fix: esbuild.charset not work with css plugin.

[NicoKam]

Description

Vite@4 has set the default config esbuild.charset to utf8, and in #12565 , the default configuration for plugin:css has also been set to utf8

This operation may lead to the generation of iconfont files being escaped, causing display errors in some cases. Although I can modify the esbuild.charset in vite.config.ts, it seems that the parameter is not passed to the plugin:css. I need to make it work.

Additional context

This is the effect of using iconfont(css) after Vite 4.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[NicoKam]

@patak-dev @bluwy CI progress has hung up. Need helps.

[sapphi-red]

Would you move the code inside resolveEsbuildMinifyOptions?

[NicoKam]

Would you move the code inside resolveEsbuildMinifyOptions?

@sapphi-red

Sorry, I don't intend to put this code in resolveEsbuildMinifyOptions because I just want to fix the code which the original author missed.

Additionally, charset is not part of the minify options, so I should not be retrieving properties which are not relevant to resolveEsbuildMinifyOptions.

If there are more places in the future that need to use options related to both charset and minify, I would consider creating a new function, such as resolveEsbuildOptionsForCssPlugin.

[sapphi-red]

I should have put #9210 in minifyCSS function or should have put #12565 in resolveEsbuildMinifyOptions. That mistake is making the inconsistency here.

If we put charset in minifyCSS, then I think log* options should be in minifyCSS too. If we put charset in resolveEsbuildMinifyOptions, then I think log* options should be in resolveEsbuildMinifyOptions. I prefer placing charset in resolveEsbuildMinifyOptions because it'll make the diff smaller.

[NicoKam]

I should have put #9210 in minifyCSS function or should have put #12565 in resolveEsbuildMinifyOptions. That mistake is making the inconsistency here.

If we put charset in minifyCSS, then I think log* options should be in minifyCSS too. If we put charset in resolveEsbuildMinifyOptions, then I think log* options should be in resolveEsbuildMinifyOptions. I prefer placing charset in resolveEsbuildMinifyOptions because it'll make the diff smaller.

I understand. I was going to ask you to fix it.
But I was hoping that it would be merged soon to solve the problem in my project, so I raised a PR myself.
I still have [email protected] in my project.
I'm glad you noticed the problem, I'm going to close the PR and let you fix the code.

Maybe you can rename resolveEsbuildMinifyOptions to resolveEsbuildOptions