fix: compatibility with react-refresh runtime in @vitejs/plugin-react #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request fixes compatibility with the runtime served by
@vitejs/plugin-react
.Background 📜
The preamble used in the
@vitejs/plugin-react
plugin imports the default export from the runtime, callinginjectIntoGlobalHook
from it.In contrast, the runtime served by this plugin does not provide a default export.
This affects compatibility with external integrations, such as Vite Ruby and the Laravel Vite integration, which were implemented to use the same preamble as the one used by
@vitejs/plugin-react
.The Fix 🔨
Adding a default export to the runtime served by this plugin.
It doesn't affect backwards compatibility, so it can be shipped in a patch release.
Notes ✏️
Although we could potentially modify the
@vitejs/plugin-react
plugin instead to use named exports, it would remain incompatible with previous versions of the backend integrations and other consumers of the runtime.This change has significantly less friction, and would allow any users of
@vitejs/plugin-react
in backend integrations to seamlessly switch to this plugin.