Skip to content

Revert changes to add source condition #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

Conversation

Pessimistress
Copy link
Collaborator

For #2523

Reverts the collection of commits downstream from #2493 until we are able to reproduce #2377

Copy link
Contributor

@chrisgervang chrisgervang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuing to iterate on this issue!

Comment on lines 12 to 13
'react-map-gl/mapbox': join(rootDir, './modules/react-mapbox/src'),
'react-map-gl/maplibre': join(rootDir, './modules/react-maplibre/src'),
'react-map-gl/mapbox': join(rootDir, './modules/main/src/mapbox.ts'),
'react-map-gl/maplibre': join(rootDir, './modules/main/src/maplibre.ts'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to be included?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Pessimistress Pessimistress merged commit e41c3ef into master Apr 16, 2025
2 checks passed
@Pessimistress Pessimistress deleted the x/revert-style-change branch April 16, 2025 00:42
Pessimistress added a commit that referenced this pull request Apr 16, 2025
* Revert "Fix addSource condition (#2524)"

This reverts commit 19e778b.

* Revert "Fix source loading condition (#2513)"

This reverts commit 3673af7.

* Revert "Fix style loading check on Source layers (#2377) (#2493)"

This reverts commit f9cd7b5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants