Skip to content

feat: export the base class MathArray、Matrix、Vector #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: export the base class MathArray、Matrix、Vector #53

wants to merge 3 commits into from

Conversation

GuoBinyong
Copy link

I'm a library developer, and I often need to inherit MathArray, Matrix, and Vector to implement some subclasses, and I often use these base classes as type constraints, but @math.gl/core doesn't expose these classes

ibgreen
ibgreen reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with exposing these as experimental / underscore exports.

They will very likely remain stable but prefer not to commit to it at this point.

Is that OK? It should unblock you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuoBinyong @ibgreen