Skip to content

[Bug] version tag in loaders is off by one #3202

Open
@zbigg

Description

@zbigg

Loader

mvt
(and others)

Description

The version property exposed by MVTWorkerLoader is off by one.

Seems like build process issue as i've checked few other WorkerLoader definitions and they suffer from same issue.

Examples:

// https://unpkg.com/@loaders.gl/[email protected]/dist/mvt-loader.js

    const VERSION = typeof "4.3.2" !== 'undefined' ? "4.3.2" : 'latest';

// affects other modules and other versions too
// https://unpkg.com/@loaders.gl/[email protected]/dist/json-loader.js

    const VERSION = typeof "4.3.1" !== 'undefined' ? "4.3.1" : 'latest';

// https://unpkg.com/@loaders.gl/[email protected]/dist/json-loader.js

    const VERSION = typeof "4.3.2" !== 'undefined' ? "4.3.2" : 'latest';


// other modules
// https://unpkg.com/@loaders.gl/[email protected]/dist/exports/arrow-loader.js

    const VERSION = typeof "4.3.2" !== 'undefined' ? "4.3.2" : 'latest';

// also new alpha
https://unpkg.com/@loaders.gl/[email protected]/dist/json-loader.js

    const VERSION = typeof "4.4.0-alpha.1" !== 'undefined' ? "4.4.0-alpha.1" : 'latest';

From @felixpalmer

Seems to be introduced in 4.2.0, 4.1.4 is correct

Expected Behavior

MVTWorkerLoader.version matches published version.

Steps to Reproduce

Inspect versions in published packages.

Example: https://unpkg.com/@loaders.gl/[email protected]/dist/mvt-loader.js

Environment

Logs

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions