Skip to content

[feat] seek video and update frame #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Jun 7, 2021

Seeking enables the user to control the preview time cursor.

In Worldview:

  • dispatch a seekTime action
  • dispatch updateFrame when seeking to new time, and the store result.

In core:

  • call seek function on DeckAdapter

A future PR will add a react component that uses this seek function.

@coveralls
Copy link

coveralls commented Jun 7, 2021

Pull Request Test Coverage Report for Build 920008159

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 919928089: 0.0%
Covered Lines: 2
Relevant Lines: 2

💛 - Coveralls

@chrisgervang chrisgervang changed the title [feat] seek video [feat] seek video and update frame Jun 8, 2021
@chrisgervang chrisgervang merged commit fb818bb into visgl:master Jun 8, 2021
@chrisgervang chrisgervang deleted the chr/seek-video branch June 9, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants