Skip to content

Webauthn Singing #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

Webauthn Singing #38

wants to merge 20 commits into from

Conversation

S0c5
Copy link
Member

@S0c5 S0c5 commented Jan 29, 2024 •
edited
Loading

Here its the first version for sube-js webauth signing and virto-core SDK

@S0c5 S0c5 changed the title Feature/virto sdk sube js Webauthn Singing Jan 29, 2024
pandres95
pandres95 requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@pandres95 pandres95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the structure of the library is really good. Some improvements can be made in terms of making users (and readers) better use and understand the library, and some others can be made to reduce redundant code, as well as unsafe calls.

@S0c5 S0c5 force-pushed the feature/virto-sdk-sube-js branch from 831409f to 7bdc392 Compare February 9, 2024 22:48
@pandres95 pandres95 self-requested a review February 10, 2024 03:11
@olanod olanod deleted the branch fix/working-version-sube July 18, 2024 09:59
@olanod olanod closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandres95 pandres95 pandres95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S0c5 @pandres95 @olanod