Initial plugin setup #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuapease
force-pushed
the
jp/initial-setup
branch
from
883f2ec to
09f47eb
Compare
joshuapease
requested review from
ten1seven,
maxfenton,
maxdmyers and
JJimmyFlynn
joshuapease
commented
Mar 28, 2024
| // databaseId: \craft\helpers\App::env('PHONE_HOME_NOTION_DATABASE'), | ||
| // ), | ||
| // ], | ||
| ]; |
There was a problem hiding this comment.
This makes it easy to configure multiple endpoints if the need ever arises.
I could see this being useful with a client who has multiple Craft sites.
We could configure one Notion endpoint for our Viget database. But also set up the client with their own database of just their sites.
maxdmyers
approved these changes
Mar 28, 2024
|
Nice work on this, @joshuapease! |
JJimmyFlynn
approved these changes
Mar 28, 2024
ten1seven
approved these changes
Mar 28, 2024
|
|
||
| Create a [new database](https://www.notion.so/help/guides/creating-a-database) in Notion. | ||
|
|
||
| No need to add any columns or properties. This plugin will create them when it's first run. |
|
|
||
| protected function defaultDescription(): ?string | ||
| { | ||
| return 'Phoning Home'; |
There was a problem hiding this comment.
☎️ Phoning Home
👽 Phoning Home
Options...
There was a problem hiding this comment.
That would be fun... I'm a little leery of emoji in SQL databases. It's probably not a huge issue... but I'd rather not think about it.
Should be resolved fully for Craft 5 (they're tweaking the default charset to be utf8mb4).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the first working version of a standalone Phone Home plugin.
Why are we doing this?
Previously this functionality was tied to our Viget Base module. But a few things prompted the idea of breaking this into it's own plugin.