Skip to content

RSDK-7848 remove side-by-side meta.json support #5008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented May 22, 2025

What changed

  • remove side-by-side support from Module.EvaluateExePath and Module.getJSONManifest
  • (incidental) automatically MkdirAll in testWriteJSON

Why

Side-by-side mode was an RDK feature that we rushed in order to support local modules under the odd execution rules of android OS. We fast-followed with meta-in-tarball which is now the standard. Side-by-side has been deprecated for a while; I'm removing now because APP-8193 requires touching these code paths, and will be simpler without the third case.

How they differ:

  • side-by-side mode means that a meta.json file is next to a local tarball, e.g. you have a mymodule/module.tar.gz and a mymodule/meta.json next to it
  • meta-in-tarball means that there is a meta.json inside the tarball at the root level. This is necessary in the local tarball case, and optional in the registry case; when present for registry modules, the meta-in-tarball entrypoint field takes precedence over what's specified in cloud

@abe-winter abe-winter requested review from jmatth and cheukt May 22, 2025 20:49
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label May 22, 2025
Copy link
Member

@jmatth jmatth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but one question: will shipping this potentially break existing deployments and if so are we ok with that? I saw in the description you said this feature has been deprecated for a while and presumably not used outside of Android so I'm guessing this is ok to ship but just wanted to be certain.

@abe-winter
Copy link
Member Author

will shipping this potentially break existing deployments

good call, will investigate before merging

Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % josh's comment

@abe-winter abe-winter merged commit 0ea77fa into viamrobotics:main Jun 3, 2025
18 checks passed
@abe-winter abe-winter deleted the aw-remove-side-by-side branch June 3, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants