Skip to content

APP-8369: Add sendEmailInvite parameter to resendOrganizationInvite #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

APP-8369: Add sendEmailInvite parameter to resendOrganizationInvite #700

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60f43b
add boolean to resend organization invite request
nandini-swami May 29, 2025
50f2149
Built new protos from e60f43b
github-actions[bot] May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions proto/viam/app/v1/app.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,9 @@ message DeleteOrganizationInviteResponse {}
message ResendOrganizationInviteRequest {
string organization_id = 1;
string email = 2;
// Set to true (the default) to send an email to the recipient of an invite. The user must accept the email to be added to the associated authorizations.
// When set to false, the user automatically receives the associated authorization on the next login of the user with the associated email address.
optional bool send_email_invite = 3;
Comment on lines +500 to +502
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: does it matter whether we pass authorizations or not here? Or does this rely on previously set authorizations from the original invite? Also aware that we don't want to duplicate the CreateOrganizationInviteRequest()

Copy link
Member Author

@nandini-swami nandini-swami May 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, will look into it and lyk!

Copy link
Member Author

@nandini-swami nandini-swami May 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it may not be necessary to have authorizations because the ticket's goal is to add the option/flag for users to send email invite, but previously we were able to request resending the invitation without authorizations. I assume it is okay because it wasn't necessary before, but I will check logic around authorizations on the App repo to confirm. I am continuing this ticket for App side of it at this PR: https://github.com/viamrobotics/app/pull/8612 (let me know if you can't access this!).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds logical to me. @bashar-515 would know more about app stuff so I defer to him 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me! I think that's a valid assumption. We can revisit in #8612

}

message ResendOrganizationInviteResponse {
Expand Down
Loading