DATA-3917 Change TabularDataByMQL format #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiepeters
reviewed
Apr 3, 2025
vijayvuyyuru
changed the title
n0nick
reviewed
Apr 3, 2025
proto/viam/app/data/v1/data.proto
Outdated
| @@ -217,6 +217,17 @@ message TabularDataBySQLResponse { | |||
| reserved "data"; | |||
| } | |||
|
|
|||
| enum DataSourceType { | |||
There was a problem hiding this comment.
please add comments documenting what each of these options mean
There was a problem hiding this comment.
and maybe rename to TabularDataSource, TabularDataSourceType?
n0nick
reviewed
Apr 3, 2025
proto/viam/app/data/v1/data.proto
Outdated
| @@ -217,6 +217,24 @@ message TabularDataBySQLResponse { | |||
| reserved "data"; | |||
| } | |||
|
|
|||
| // TabularDataSourceType specifies the data source type for querying. | |||
| enum TabularDataSourceType { | |||
| DATA_SOURCE_TYPE_UNSPECIFIED = 0; | |||
Co-authored-by: Sagie Maoz <[email protected]>
Co-authored-by: Sagie Maoz <[email protected]>
n0nick
reviewed
Apr 3, 2025
n0nick
approved these changes
Apr 3, 2025
Co-authored-by: Sagie Maoz <[email protected]>
vijayvuyyuru
added
the
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.