is_directory #500
Merged
is_directory #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etai-shuchatowitz
force-pushed
the
DATA-2586/directory
branch
from
5f114f5 to
5a1e707
Compare
tahiyasalam
approved these changes
May 16, 2024
agreenb
approved these changes
May 16, 2024
Yes |
etai-shuchatowitz
force-pushed
the
DATA-2586/directory
branch
from
4d9393b to
cf5fc05
Compare
etai-shuchatowitz
added
the
ready-for-protos
etai-shuchatowitz
removed
the
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the PR to be a feature branch. Need this to be approved in order to test with local
appI think (so the proto compiles). Am I doing that right?Old PR: #496
Context: https://viam.atlassian.net/browse/DATA-2586?atlOrigin=eyJpIjoiNjdlMmRiNjkyZDA5NGQ0NTkzZWI0NzQxMTBmNDU1MDMiLCJwIjoiaiJ9
App PR: https://github.com/viamrobotics/app/pull/4726
Do I get a prize for being PR #500? Like Modest Mouse tickets or something?