Skip to content

RSDK-7371: remove AnalogStatus and DigitalInterruptStatus from common API #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2024
Merged

RSDK-7371: remove AnalogStatus and DigitalInterruptStatus from common API #490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bccb26f
remove analog and digital interrupt statuses
martha-johnston Apr 25, 2024
2ae340c
Merge branch 'main' into rsdk-7371
martha-johnston Apr 29, 2024
dc95147
Built new protos from 2ae340c
github-actions[bot] Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions proto/viam/common/v1/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,6 @@ message ResourceName {
string name = 4;
}

message AnalogStatus {
// Current value of the analog reader of a robot's board
int32 value = 1;
}

message DigitalInterruptStatus {
// Current value of the digital interrupt of a robot's board
int64 value = 1;
}

/* Pose is a combination of location and orientation.
Location is expressed as distance which is represented by x , y, z coordinates. Orientation is expressed as an orientation vector which
is represented by o_x, o_y, o_z and theta. The o_x, o_y, o_z coordinates represent the point on the cartesian unit sphere that the end of
Expand Down
4 changes: 2 additions & 2 deletions proto/viam/component/board/v1/board.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ service BoardService {
}

message Status {
map<string, viam.common.v1.AnalogStatus> analogs = 1;
map<string, viam.common.v1.DigitalInterruptStatus> digital_interrupts = 2;
map<string, int32> analogs = 1;
map<string, int64> digital_interrupts = 2;
}

message SetGPIORequest {
Expand Down