Skip to content

fix(prune): preserve pnpmfileChecksum in lockfile #9960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chris-olszewski
Copy link
Member

Description

Closes #9947

Testing Instructions

[0 olszewski@macbookpro] /tmp/pnpmcjs $ turbo_dev --skip-infer prune web
turbo 2.4.2

Generating pruned monorepo for web in /private/tmp/pnpmcjs/out
 - Added @repo/eslint-config
 - Added @repo/typescript-config
 - Added @repo/ui
 - Added web
[0 olszewski@macbookpro] /tmp/pnpmcjs $ cd out 
[0 olszewski@macbookpro] /tmp/pnpmcjs/out $ cp ../.pnpmfile.cjs ./
[0 olszewski@macbookpro] /tmp/pnpmcjs/out $ pnpm i --frozen-lockfile
Scope: all 5 workspace projects
Lockfile is up to date, resolution step is skipped
Packages: +452
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 452, reused 452, downloaded 0, added 452, done

devDependencies:
+ prettier 3.5.0
+ turbo 2.4.2
+ typescript 5.7.3

Done in 3.4s
[0 olszewski@macbookpro] /tmp/pnpmcjs/out $ rg 'pnpmfileChecksum'
pnpm-lock.yaml
5:pnpmfileChecksum: kpphteni3rdug2puxczjfk5mle

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:01pm

@chris-olszewski chris-olszewski marked this pull request as ready for review February 13, 2025 17:01
@chris-olszewski chris-olszewski requested a review from a team as a code owner February 13, 2025 17:01
@chris-olszewski chris-olszewski merged commit c5ad9a8 into main Feb 13, 2025
39 checks passed
@chris-olszewski chris-olszewski deleted the chrisolszewski/turbo-4480-pnpm-turbo-prune-removes-pnpmfilechecksum-from-lockfile branch February 13, 2025 17:56
joshnuss pushed a commit to joshnuss/turborepo that referenced this pull request Feb 15, 2025
### Description

Closes vercel#9947

### Testing Instructions

```
[0 olszewski@macbookpro] /tmp/pnpmcjs $ turbo_dev --skip-infer prune web
turbo 2.4.2

Generating pruned monorepo for web in /private/tmp/pnpmcjs/out
 - Added @repo/eslint-config
 - Added @repo/typescript-config
 - Added @repo/ui
 - Added web
[0 olszewski@macbookpro] /tmp/pnpmcjs $ cd out 
[0 olszewski@macbookpro] /tmp/pnpmcjs/out $ cp ../.pnpmfile.cjs ./
[0 olszewski@macbookpro] /tmp/pnpmcjs/out $ pnpm i --frozen-lockfile
Scope: all 5 workspace projects
Lockfile is up to date, resolution step is skipped
Packages: +452
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 452, reused 452, downloaded 0, added 452, done

devDependencies:
+ prettier 3.5.0
+ turbo 2.4.2
+ typescript 5.7.3

Done in 3.4s
[0 olszewski@macbookpro] /tmp/pnpmcjs/out $ rg 'pnpmfileChecksum'
pnpm-lock.yaml
5:pnpmfileChecksum: kpphteni3rdug2puxczjfk5mle
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pnpm] turbo prune removes pnpmfileChecksum from lockfile
2 participants