feat(turbo): framework conditionals #9853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
approved these changes
Jan 30, 2025
chris-olszewski
approved these changes
Jan 30, 2025
| @@ -33,6 +48,27 @@ impl Framework { | |||
| pub fn env_wildcards(&self) -> &[String] { | |||
| &self.env_wildcards | |||
| } | |||
|
|
|||
| pub fn resolved_env_conditionals( | |||
There was a problem hiding this comment.
Super minor, but I think we should offer a single method here that combines env_wildcards and resolved_env_conditionals so the task hasher just makes one call. It's a lot easier to write tests on that framework methods than task hasher methods.
tknickman
force-pushed
the
tomknickman/turbo-4393-investigate-disabling-caching-by-default-for-next-on-vercel
branch
from
ffab583 to
80ae408
Compare
tknickman
deleted the
tomknickman/turbo-4393-investigate-disabling-caching-by-default-for-next-on-vercel
branch
|
Is there any more info on why VERCEL_DEPLOYMENT_ID has to be part of the build cache for builds with skew protection enabled? This causes a huge increase in build times on Vercel because every task becomes a miss on a new deployment, i.e. there’s no way to reuse remote-cached work in vercel builds if turborepo adds VERCEL_DEPLOYMENT_ID as part of the cache key |
|
Never mind, I found #10126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support framework conditional env vars
Testing Instructions