Skip to content

chore: update to Rust 1.87.0 #10482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

chore: update to Rust 1.87.0 #10482

merged 1 commit into from
May 30, 2025

Conversation

ognevny
Copy link
Contributor

@ognevny ognevny commented May 15, 2025

Description

  • clippy::result_large_err requires huge code refactoring, so ignore this lint
  • extract_if features are now stable
  • use io::Error::other where applicable
  • some more small clippy suggestions

Testing Instructions

@ognevny ognevny requested a review from a team as a code owner May 15, 2025 18:46
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage pkg: turbo-repository labels May 15, 2025
@vercel Vercel
Copy link

vercel bot commented May 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 7:59am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 7:59am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 7:59am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 7:59am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 7:59am

@vercel Vercel
Copy link

vercel bot commented May 15, 2025

@ognevny is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ognevny ognevny force-pushed the rust-1.87.0 branch 3 times, most recently from fad4bc3 to 9aec2bf Compare May 25, 2025 07:37
@ognevny
Copy link
Contributor Author

ognevny commented May 27, 2025

@chris-olszewski can you have a look into it, please?

chris-olszewski
chris-olszewski requested changes May 27, 2025
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to suggest keeping the code in color_selector as is and ignore the lint for the time being. Just want to be super sure there isn't some change to lock releasing that I'm not understanding in this PR.

@ognevny ognevny force-pushed the rust-1.87.0 branch 3 times, most recently from 7c6439d to 4c2533b Compare May 28, 2025 14:27
@ognevny
Copy link
Contributor Author

ognevny commented May 30, 2025

@chris-olszewski I've reverted color_selector change and ignored the lint

@chris-olszewski chris-olszewski merged commit 9b1166d into vercel:main May 30, 2025
41 of 47 checks passed
@ognevny ognevny deleted the rust-1.87.0 branch May 30, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
needs: triage New issues get this label. Remove it after triage pkg: turbo-repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ognevny @chris-olszewski