feat: add noUpdateNotifier option to turbo.json #10409
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devin-ai-integration
bot
requested review from
anthonyshew and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
turbo-orchestrator
bot
added
area: docs
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
bot
changed the title
crates/turborepo-lib/src/shim/mod.rs
Outdated
| let builder = crate::config::TurborepoConfigBuilder::new(&repo_state.root); | ||
| let config = builder.build().unwrap_or_default(); |
There was a problem hiding this comment.
We need to be careful here as there could be a delta between the configuration loaded this way and the actual configuration.
The only one I know of is --root-turbo-json which changes the location of the turbo.json used for configuration. Can you add that flag to the shim arg parser and use it if present in the config builder? Please add tests in the shim/parser.rs module.
crates/turborepo-lib/build.rs
Outdated
| @@ -2,6 +2,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| let tonic_build_result = tonic_build::configure() | |||
| .build_server(true) | |||
| .file_descriptor_set_path("src/daemon/file_descriptor_set.bin") | |||
| .protoc_arg("--experimental_allow_proto3_optional") | |||
There was a problem hiding this comment.
@devin-ai-integration Seriously, rewrite and get rid of this or you're fired.
| let (spans, args_string) = | ||
| Self::get_spans_in_args_string(vec![idx], env::args().skip(1)); | ||
|
|
||
| return Err(Error::EmptyCwd { |
There was a problem hiding this comment.
Can you make a new error variant for this specific error?
| ..Default::default() | ||
| } | ||
| ; "root turbo json equals" | ||
| )] |
There was a problem hiding this comment.
Can you add a test case for when the path is provided as an absolute path?
| @@ -301,6 +328,7 @@ mod test { | |||
| pub color: bool, | |||
| pub no_color: bool, | |||
| pub relative_cwd: Option<&'static [&'static str]>, | |||
| pub relative_root_turbo_json: Option<&'static [&'static str]>, | |||
There was a problem hiding this comment.
We can simplify this by just storing the path instead of "components" since were' just using the first one.
| pub relative_root_turbo_json: Option<&'static [&'static str]>, | |
| pub relative_root_turbo_json: Option<&'static str>, |
chris-olszewski
force-pushed
the
devin/1745990165-no-update-notifier
branch
from
c1a3b06 to
c292090
Compare
Allow disabling checking for a new version of Turborepo via turbo.json
This PR adds a
noUpdateNotifieroption toturbo.jsonthat allows disabling the update notificationthat appears when a new version of Turborepo is available.
Changes
noUpdateNotifierfield to theRawTurboJsonstructConfigurationOptionsstructFixes #8564
Link to Devin run: https://app.devin.ai/sessions/0c3ac344fa1b4ba785417b7856eceb4f
Requested by [email protected]