fix(microfrontends): respect packageName field #10383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
commented
Apr 24, 2025
| @@ -394,6 +394,13 @@ impl Engine<Built> { | |||
| self.task_graph.node_weights() | |||
| } | |||
|
|
|||
| pub fn task_ids(&self) -> impl Iterator<Item = &TaskId<'static>> { | |||
There was a problem hiding this comment.
Future work is removing the concept of a "root" task node since that only exists due to limitation of Go graphing library.
| @@ -20,7 +20,8 @@ pub struct MicrofrontendsConfigs { | |||
|
|
|||
| #[derive(Debug, Clone, Default, PartialEq)] | |||
| struct ConfigInfo { | |||
| tasks: HashSet<TaskId<'static>>, | |||
| // A map from tasks declared in the configuration to the application that they belong to | |||
| tasks: HashMap<TaskId<'static>, String>, | |||
There was a problem hiding this comment.
We need to store the application name as that is what the microfrontends local proxy uses to identify locally running applications.
| @@ -269,11 +266,31 @@ impl<'a> CommandProvider for MicroFrontendProxyProvider<'a> { | |||
| } | |||
| } | |||
|
|
|||
| /// A trait for fetching package information required to execute commands | |||
| pub trait PackageInfoProvider { | |||
There was a problem hiding this comment.
This trait allows us to test the microfrontends command generation without building an entire package graph.
| Self { | ||
| repo_root, | ||
| package_graph, | ||
| tasks_in_graph, | ||
| tasks_in_graph: tasks_in_graph.cloned().collect(), |
There was a problem hiding this comment.
Moved this logic over to Engine so we could test this command provider without building an entire task graph.
| .unwrap() | ||
| .unwrap(); | ||
| assert!( | ||
| cmd.label().ends_with("--names docs-app"), |
There was a problem hiding this comment.
Key here is that we pass the "app name" and not the package name
tknickman
approved these changes
Apr 25, 2025
| Self { | ||
| repo_root, | ||
| package_graph, | ||
| tasks_in_graph, | ||
| tasks_in_graph: tasks_in_graph.cloned().collect(), |
Co-authored-by: Thomas Knickman <[email protected]>
chris-olszewski
deleted the
chrisolszewski/turbo-4679-debug-turborepo-local-dev-proxy-not-starting-automatically
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does 2 things:
microfrontends.jsonthat is not present in the monorepopackageNameover theapplicationskey if presentTesting Instructions
Added unit tests.
Verified warnings now are present if you reference a package that isn't found in the monorepo:
Verified that proxy is now started if every application uses a
packageNamethat differs from the key inapplications.