feat: allow specifying concurrency in config / environment #10236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: docs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@kade-robertson is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
kade-robertson
commented
Mar 26, 2025
chris-olszewski
requested changes
Apr 8, 2025
chris-olszewski
approved these changes
Apr 11, 2025
|
If you could rebase, I'll work on getting this merged and released in the next canary. Thank you for the contribution! |
kade-robertson
force-pushed
the
extend-concurrency-option
branch
from
4296e89 to
447b0e8
Compare
Should be good to go! |
This was referenced Apr 24, 2025
chris-olszewski
pushed a commit
that referenced
this pull request
Apr 25, 2025
### Description This is a follow-up fix to: #10236 As it turns out, this change presented a regression in how the `--concurrency` flag behaves in watch mode. Previously, since this flag was read from the `execution_args` directly, it worked as expected. After switching it to read from `config`, it no longer worked in `watch` mode, as `Args` would only extract correctly from the `Run` command. This change lets the `Args::execution_args()` getter return the execution args from the watch command that has been run, if present. This _is_ a pretty significant change, as previously _none_ of the run mode execution args would be respected in watch mode. I'm not totally confident this is desired. The alternative is to bring back the special case for `concurrency`, and try to read from execution_args directly when parsing it, and falling back to `config` otherwise. ### Testing Instructions 1. Clone `main` and `pnpm build:turbo` 2. Run `./path/to/turbo watch <some-cmd>` in a repository where more than 10 tasks (the default) are persistent 3. Observe that even specifying `--concurrency=<task-count>` does not override this setting 4. Checkout the v2.5.0 commit and rebuild 5. Run the same test, and observe that the concurrency flag works as expected 6. Finally, clone this branch and rebuild 7. Run the same test, and observe that the concurrency flag works as expected
chris-olszewski
pushed a commit
that referenced
this pull request
Apr 25, 2025
### Description This is a follow-up fix to: #10236 Unfortunately I didn't notice `turbo-types` is where the schema actually lives and is generated from, so the configuration schema never got updated to support this option. ### Testing Instructions 1. Install turborepo 2.5.1 2. Add a "concurrency" option to your `turbo.json` 3. Observe that using the public schema URL in `$schema` flags the concurrency option as an unknown property. 4. Clone this branch 5. Change the path in `$schema` to point to the schema in this branch 6. Observe the previous warning goes away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a couple new ways to configure task run concurrency:
TURBO_CONCURRENCYenvironment variableconcurrencyconfiguration value inturbo.jsonThese options should follow the same precedence rules for other options which are made available in multiple locations. I think the environment variable is the most valuable to me (IMO), as this would make it a lot easier to turn off or drastically reduce concurrency in CI scenarios with restricted performance, where running multiple test suites at the same time could cause flaky results due to timeouts, or too much resource contention in general scenarios. Being able to specify this in the configuration file is maybe less valuable, but there are situations where it might be desirable.
The
--concurrencyoption is obviously already available and certainly usable in combination with other changes (enforcing the use of an alias, or setting up differentpackage.jsonscripts for CI and local development), but enabling this to be enforced via the config or an environment variable makes it a lot easier to turn off concurrency in CI, for example.There is some active desire for this feature to exist:
Notably, this does not enable configuring concurrency per task, which was part of one of the discussions here. That seemed like a much larger lift vs. just adding an environment variable and config option that behaved exactly like the CLI argument already does. There is still some demand for this "simple" option.
Testing Instructions
turboturbo.json, with the same behaviour as the CLI argument.TURBO_CONCURRENCYenvironment variable, with the same behaviour as the CLI argument.I've done this checks (with some print debugging) on repos where I use
turboand it seems to work as expected. I've added some unit and integration tests where it seemed to make the most sense, but there were some spots where it was unclear if I should add something. If I've missed a spot or need some additional checks, let me know!