refactor: fix all react-hooks/exhaustive-deps warnings in useSWR #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 397339f:
|
koba04
force-pushed
the
fix-all-exhaustive-deps-warnings
branch
from
fd10812 to
397339f
Compare
shuding
approved these changes
Jan 26, 2021
shuding
reviewed
Jan 26, 2021
Comment on lines
+555
to
+560
| // FIXME: | ||
| // `fn` and `config` might be changed during the lifecycle, | ||
| // but they might be changed every render like this. | ||
| // useSWR('key', () => fetch('/api/'), { suspense: true }) | ||
| // So we omit the values from the deps array | ||
| // even though it might cause unexpected behaviors. |
There was a problem hiding this comment.
Yeah this is expected, I'm okay with the eslint ignore mark here. 👍
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR to fix all
react-hooks/exhaustive-depswarnings.The PR fixes the warnings in
useSWR, which adds some deps formemoizedStateand disables the rule forrevalidate.For
memoizedState, I've added all deps in the deps array.boundMutateis an immutable function, so we can omit it, but I've added it to the deps array to enablereact-hooks/exhaustive-depsrule. It's an immutable function, so it shouldn't be a problem.For
revalidate, I've disabled thereact-hooks/exhaustive-depsrule becausefnandconfigare defined as the arguments ofuseSWRcall, which means those values would be changed every time.I could add
eventsCallback,fnArgs,keyErr, andkeyValidatinginto the deps array. It should be safe because they only depend onkeythat is already in the deps array.But it makes tests flakier because current tests depends on JavaScript timer naively. If I added meaning-less values in the deps array for
revalidate, tests would be failed frequently. So I didn't add them into the deps array.I'll investigate the way to fix flaky tests.