Skip to content

fix: add protection for navigator #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 9, 2021

related to #522

navigator.isOnline might be directly accessed in some corner cases leading to crashes.

known runtime:

  • node.js with next.ks
  • ink

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 20830cf:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration

@huozhi
Copy link
Member Author

huozhi commented Jan 9, 2021

UT useSWR - refresh › should update data upon interval changes -- changes happened during revalidate seems fails sometimes randomly on travisCI, not sure if it's about it's a bit slow to cause it. after manually restart the build, it gets back to normal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants