fix: mark isValidating as false when key is falsy #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b21e3ea:
|
shuding
reviewed
Nov 17, 2020
huozhi
commented
Nov 17, 2020
| @@ -719,7 +719,7 @@ function useSWR<Data = any, Error = any>( | |||
| isValidating: { | |||
| get: function() { | |||
| stateDependencies.current.isValidating = true | |||
| return stateRef.current.isValidating | |||
| return key ? stateRef.current.isValidating : false | |||
There was a problem hiding this comment.
I can only come up with this simple solution that return false when key is falsy.
since when key changes swr will always clean up and unmountedRef.current changes to true. so dispatch won't work and in won't pass the internal condition.
There was a problem hiding this comment.
This fix sounds good until we have a better and complete refactoring to the codebase. 👍
huozhi
changed the title
shuding
added a commit
that referenced
this pull request
Dec 16, 2020
* 0.3.8 * replace rIC with rAF (#744) * Fix race condition when calling mutate synchronously (#735) * fix race condition when calling mutate synchronously * fix test * add comment * fix code reviews * refactor: support SSR in Deno (#754) * refactor: support SSR in Deno * refactor: improve Deno determining * Add @ts-ignore Co-authored-by: Shu Ding <[email protected]> Co-authored-by: Shu Ding <[email protected]> * fix eslint error (#768) * Fix `mutateCallback` types (#745) * Fix `mutateCallback` types * WIP * Add CodeSandbox CI (#769) * add CodeSandbox CI * add new line * fix install cmd Co-authored-by: Paco <[email protected]> * dispatch's payload type is actionType and run lint (#772) * chore: payload is actionType * chore: move a ts-ignore comment * Fix suspense (#777) * fix #494 * add comment * rename to initialMountedRef * 0.3.9 * fix: mark isValidating as false when key is falsy (#757) * fix: tear down when key turns to empty * use false for empty key * Fix README.md typo (#783) '/api/data' => '/api/user' in "Multiple Arguments" * fix: do mount check in config callback (#787) * Update api-hooks example README.md (#790) Updated the Vercel deploy link to the correct directory * Return '@null' if args is null ASAP (#767) * chore: return 'null' if arg[i] is null ASAP * chore: update comment * chore: use continue * Bump ini from 1.3.5 to 1.3.8 (#806) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update test Co-authored-by: Shu Ding <[email protected]> Co-authored-by: X <[email protected]> Co-authored-by: Umidbek Karimov <[email protected]> Co-authored-by: Paco <[email protected]> Co-authored-by: matamatanot <[email protected]> Co-authored-by: Jiachi Liu <[email protected]> Co-authored-by: sAy <[email protected]> Co-authored-by: William Crutchfield <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #199
* tear down work when key turns to empty, unmount state should be false if it's mounted before.* dispatchisValidatingasfalsescenario: key: v1 -> v2 -> ''
in this case, when transfer to empty key the unmountedRef will be set totrue, which lead dispatch take no effect. so I set it to true if it's not really unmounted.then dispatchisValidatingtofalseto ignore the ongoing requests.updatekeyRefto match key, then isValidating getter will retrive states fromstateRefforcedly return false when key is falsy