Skip to content

fix: isValidating when an error occurred #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

koba04
Copy link
Collaborator

@koba04 koba04 commented Aug 28, 2021

Fixes #1395.
I guess SWR should update the cache value for isValidating when an error occurred.

@koba04 koba04 requested review from huozhi and shuding as code owners August 28, 2021 12:43
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e62f72:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@shuding
Copy link
Member

shuding commented Aug 28, 2021

Good catch, thank you!

@shuding shuding merged commit 7fd370f into vercel:master Aug 28, 2021
@koba04 koba04 deleted the fix-isvalidating-on-error branch August 28, 2021 13:04
@koba04
Copy link
Collaborator Author

koba04 commented Aug 28, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isValidating is still true on error
2 participants