-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor code structure #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code structure #1350
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47874fd:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left 2 small comments. great job!
const boundMutate: SWRResponse<Data, Error>['mutate'] = useCallback( | ||
(newData, shouldRevalidate) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw those changes on trigger branch few days ago, lgtm 👍
RevalidateCallback
andStateUpdateCallback
. The revalidate callback receives internal event (onfocus
,onreconnect
,onmutate
) that might trigger a revalidation to the hook. The state update callback handles hooks'setState
events. This is the initial step for some future features.