Skip to content

lint-staged: remove lint, fix prettier #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2021
Merged

lint-staged: remove lint, fix prettier #1347

merged 3 commits into from
Aug 17, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 17, 2021

  • run type checking on pre-push git hook, to speed up local development
  • fix prettier, lint command with lint-staged for changed files only

@huozhi huozhi requested a review from shuding as a code owner August 17, 2021 11:04
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 17, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e23d33c:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@shuding
Copy link
Member

shuding commented Aug 17, 2021

I think we should still run linter and type checker on each commit locally, so we can fix issues immediately rather than waiting on the CI and then fix them with another commit.

@huozhi
Copy link
Member Author

huozhi commented Aug 17, 2021

Moved type-checking to pre-push since it requires context of all files, but eslint and prettier only requires changed files. So we can still keep them in pre-commit phase

@shuding shuding merged commit 7f04f40 into master Aug 17, 2021
@shuding shuding deleted the speed-up-cmd branch August 17, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants