Skip to content

Chore: code refactoring, comment and test improvements for useSWRInfinite #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Jul 30, 2021

One notable change is that we no longer use an object to pass the context to fetcher: { data: originalData, force: false }, instead an array is used [false, originalData].

The test also ensures that #590 is fixed.

@shuding shuding requested a review from huozhi as a code owner July 30, 2021 16:15
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 30, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dbc6450:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@huozhi huozhi merged commit dc1444f into master Jul 30, 2021
@huozhi huozhi deleted the fix-size-revalidation branch July 30, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants