Skip to content

enhance: simplify deno detection #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2021
Merged

enhance: simplify deno detection #1299

merged 1 commit into from
Jul 18, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jul 18, 2021

For Deno, window is globalThis, so Deno === window.Deno === globalThis.Deno. Ignore the case that user customized their own global variable window.Deno = xxx

@huozhi huozhi requested a review from shuding as a code owner July 18, 2021 16:08
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 69fde36:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@huozhi huozhi force-pushed the simplify-deno-cond branch from 6775a56 to 69fde36 Compare July 18, 2021 16:24
@shuding shuding merged commit ec3a15e into master Jul 18, 2021
@shuding shuding deleted the simplify-deno-cond branch July 18, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants