Fix types generate #1266
Merged
Fix types generate #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 789c349:
|
shuding
reviewed
Jul 4, 2021
shuding
reviewed
Jul 4, 2021
shuding
reviewed
Jul 6, 2021
shuding
reviewed
Jul 6, 2021
test/tsconfig.json
Outdated
Comment on lines
8
to
10
| "..", | ||
| "./test", | ||
| "./jest-setup.ts" |
There was a problem hiding this comment.
Maybe:
Suggested change
| "..", | |
| "./test", | |
| "./jest-setup.ts" | |
| "../test", | |
| "../jest-setup.ts" |
src/utils/serialize.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import hash from './hash' | |||
| import { Key } from '../types' | |||
| import { Key } from 'swr' | |||
There was a problem hiding this comment.
Feels like a hack, it seems to be working fine though.
huozhi
commented
Jul 6, 2021
shuding
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
types generation in subpath module dist files.
in
immutable/dist/immutable/index.d.ts. but source files won't be included in the published npm packagebefore
after, import from published module