Code optimizations #1150
Merged
Code optimizations #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ed3ba4d:
|
promer94
reviewed
May 4, 2021
huozhi
reviewed
May 4, 2021
| @@ -24,6 +25,10 @@ import { | |||
|
|
|||
| type Revalidator = (...args: any[]) => void | |||
|
|
|||
| // Generate strictly increasing timestamps. | |||
| let __timestamp = 0 | |||
There was a problem hiding this comment.
do you feel it's okay to start timestamp from 1 to avoid some issue like !now() ? not blocking
There was a problem hiding this comment.
👍 (where are we using !now() btw?)
There was a problem hiding this comment.
we used to have this issue in #1075
There was a problem hiding this comment.
I just checked again, we are using const now = () => ++__timestamp so it will be starting from 1 I think.
huozhi
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a couple of code optimizations in this PR for better structure and code reusing. Also handles the case that
undefinedis manually set to another value*.As a result, here's the size of the built
dist/index.jswith this PR:*Although Rollup handles it automatically by changing it to
void 0, it's great to have it in the source code. This trick also makes the built file smaller.