fix #1056

[promer94]

https://codesandbox.io/s/swr5-concurrent-suspense-bug-onut5?file=/src/App.tsx

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0bc51dd:

Sandbox	Source
SWR-Basic	Configuration
SWR-States	Configuration
SWR-Infinite	Configuration
swr5-concurrent-suspense-bug	PR

[shuding]

Can you also add https://codesandbox.io/s/swr5-concurrent-suspense-bug-onut5?file=/src/App.tsx as a test case? Thanks!

[shuding]

Thank you!

[damusnet]

@shuding @promer94 @pacocoursey Hi, this issue has been fixed 3 weeks ago, yet, as far as I can tell, it still has not been published. Apparently there was briefly a v0.5.5 which was then pulled. What's the hold up? Cheers

[shuding]

Hi @damusnet we're aiming for the 1.0 version so new changes will be released with the "beta" tag, please try install swr@beta and this PR should be included.

[damusnet]

Thanks @shuding for the quick response.

Is there any chance this one bug fix could make it to the v0 branch? Especially if the v1 branch is going to have breaking changes, or is further out, it would be very useful for us users to have a faster way to fix this issue.

[damusnet]

edit: I see now that v0.5.5 is still available on npm, along with multiple v1 betas. The issue in my opinion is that in the absence of tagged releases with release notes here on GitHub, this is hard to follow for people like me who are not intimately familiar with the development of the project. I can't for instance just install swr@beta v1 without knowing if there are any breaking changes.

What happened with v0.5.5? Why does it not have a tag and release notes here on GitHub like previous releases?

[shuding]

@damusnet 0.5.5 was a hot-fix for some license related issue, and it didn't go through the normal release flow. I see your point but it's harder for the maintainers to keep tracking both versions, as patches need to be applied to both branch when developing, and there will be huge amount of conflicts when merging back potentially. I can do a patch to the 0.x version for you (let me know if you need it urgently, I can do a release tomorrow), but still encourage you to try out 1.0 (there's no breaking change in the current 1.0 beta) because new bug fixes won't be applied to 0.x eventually when 1.0 is out.

[damusnet]

Thank you for being so understanding and accommodating. I (and hopefully others) would really appreciate if you could cut a v0.x release with the usual release notes. All I need is some traceability (version points to tag points to commit hash, etc.).

[damusnet]

Hi @shuding

Sorry to insist, but as far as I can tell, it's been another three weeks since we last talked, and there still doesn't seem to be any non-beta release, v1.x or v0.x, that addresses the original bug fixed in this thread.

Can you please publish a v0.5.6?

[shuding]

@damusnet I just published 0.5.6.

The tricky part for us is, we have to cherry-pick this fix to the v0.5.5 commit, while we are already working on the new version for a while. We don't have 2 branches to maintain both stable and beta and make sure every fix is applied to both (and we don't have the time). In the future, we will encourage people to upgrade to the latest beta to access new features and bug fixes earlier. Otherwise they have to wait until the stable release. Thanks for your understanding!

[damusnet]

@shuding thanks a lot, really appreciate the new release, and totally understand the concerns!