-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Micro optimizations #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro optimizations #1018
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 972e4e7:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lgtm. the lint warning is a fake one. disabling it or rollback to array destruction are both acceptable.
eslint hooks ignore the none array pattern for useState, haven't found any useful case to work around yet
@huozhi It seems like the linter didn't yell, so I think it's fine :) |
@shuding care to point out what is the |
@ranisalt it's an implementation detail inside SWR, previously we are using |
Make the code cleaner and more consistent:
useState({})[1]
pattern for re-rendering the componentCache
ctx@
,inf@
,len@
), and internal cache property name shorteraddRevalidator
return the ubsubscriberCloses #896.