keep old esm directory structure #1011
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 37a55b8:
|
tsconfig.json
Outdated
| @@ -24,7 +25,7 @@ | |||
| }, | |||
| "include": [ | |||
| "src/**/*", | |||
There was a problem hiding this comment.
#TIL
Importantly, rootDir does not affect which files become part of the compilation. It has no interaction with the include, exclude, or files tsconfig.json settings.
https://www.typescriptlang.org/tsconfig#rootDir
There was a problem hiding this comment.
That is confusing, so includes only determines which definitions get generated?
There was a problem hiding this comment.
rootDir is used to keep the output's directory structure simple and clean
includes determines which file (must be in rootDir) will be compiled by tsc
We should have a separate tsconfig.test.json which is only used for ts-jest
In this way jest-setup.ts will not affect the output's directory structure anymore
#932 accidentally changed the esm directory structure.