Skip to content

Fix template literals escaping issues #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2019
Merged

Fix template literals escaping issues #577

merged 2 commits into from
Aug 31, 2019

Conversation

giuseppeg
Copy link
Collaborator

Mistakenly we were using the cooked version of the template element. Hopefully this is an improvement and won't regress in other situations.

For a difference between cooked and raw see https://2ality.com/2016/09/template-literal-revision.html#tag-functions-and-escape-sequences

@giuseppeg giuseppeg requested review from lfades and ijjk August 30, 2019 15:57
ijjk
ijjk approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@giuseppeg giuseppeg merged commit eea954a into master Aug 31, 2019
@giuseppeg giuseppeg deleted the fix-tmpl-literals-escaping branch August 31, 2019 06:29
@giuseppeg giuseppeg mentioned this pull request Aug 31, 2019
Closed
@giuseppeg giuseppeg mentioned this pull request Nov 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giuseppeg @ijjk