-
Notifications
You must be signed in to change notification settings - Fork 156
Fix argon2
with special case
#53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm install argon
doesn't seem to work on Windows
@lucleray This package doesn't seem to install at all on Windows so I excluded from the Windows CI. The most important test here is for Linux. |
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 89.97% 90.01% +0.03%
==========================================
Files 10 10
Lines 988 991 +3
==========================================
+ Hits 889 892 +3
Misses 99 99
Continue to review full report at Codecov.
|
@lucleray It turns out that Linux and Mac needed different binary paths so I included both. Windows of course doesn't install at all so its still excluded. |
Hi! I'm the maintainer for Argon2. What do you mean that it does not work on Windows? We have had CI running on Windows for a while with no issues, and while some users report errors on compilation, it's usually due to missing build tools. Could you elaborate so we can fix it? |
Hi @ranisalt The commits above have the CI results from GitHub Actions. Take a look at this one https://github.com/zeit/node-file-trace/runs/198427474 |
node-gyp output is horribly awful, but from |
That's strange because the linked document says it contains Is this something that needs to be reported to the GH Actions team or do we need to install something in CI before building? |
Honestly I don't know, my builds on Windows are failing too. We have Appveyor working but there you can pick a Visual Studio version and it installs all components, compilers included. Maybe on Windows we can override compiler location with an environment variable, but I have no clue how. |
Fixes #45
This package doesn't seem to work on Windows so I excluded from the Windows CI.