Skip to content

Add special case for bull #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2019
Merged

Add special case for bull #37

merged 4 commits into from
Aug 7, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 7, 2019

Fixes #35

@styfle styfle marked this pull request as ready for review August 7, 2019 01:32
@styfle styfle requested a review from lucleray as a code owner August 7, 2019 01:32
@styfle styfle requested a review from TooTallNate August 7, 2019 01:32
@codecov-io
Copy link

codecov-io commented Aug 7, 2019 •
edited
Loading

Codecov Report

Merging #37 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   89.91%   89.93%   +0.02%     
==========================================
  Files          10       10              
  Lines         982      984       +2     
==========================================
+ Hits          883      885       +2     
  Misses         99       99
Impacted Files Coverage Δ
src/utils/special-cases.js 95.77% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc8200...c94b832. Read the comment docs.

TooTallNate
TooTallNate approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@TooTallNate TooTallNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did it need to be disabled on Windows?

@styfle styfle added the automerge Automatically merge PR once checks pass label Aug 7, 2019
@styfle styfle merged commit 67d691f into master Aug 7, 2019
@styfle styfle deleted the fix-bull branch August 7, 2019 23:32
@styfle styfle mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@lucleray lucleray lucleray approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for bull
4 participants
@styfle @codecov-io @TooTallNate @lucleray