Skip to content

Add log option to types #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Add log option to types #19

merged 1 commit into from
Jul 13, 2019

Conversation

guybedford
Copy link
Contributor

This adds the log option to the typing of the library.

@guybedford guybedford requested a review from styfle as a code owner July 13, 2019 20:51
@codecov-io
Copy link

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files          10       10           
  Lines         944      944           
=======================================
  Hits          845      845           
  Misses         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679231c...97b9667. Read the comment docs.

@styfle
Copy link
Member

styfle commented Jul 13, 2019

At some point, I would like to change the source code to typescript so we don't have mismatches like this.

@styfle styfle merged commit c5d6db9 into master Jul 13, 2019
@styfle styfle deleted the log-type branch July 13, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants