Skip to content

Remove subissues from Issue #79988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions crates/napi/src/next_api/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ pub struct NapiIssue {
pub detail: Option<serde_json::Value>,
pub source: Option<NapiIssueSource>,
pub documentation_link: String,
pub sub_issues: Vec<NapiIssue>,
}

impl From<&PlainIssue> for NapiIssue {
Expand All @@ -309,11 +308,6 @@ impl From<&PlainIssue> for NapiIssue {
severity: issue.severity.as_str().to_string(),
source: issue.source.as_ref().map(|source| source.into()),
title: serde_json::to_value(StyledStringSerialize::from(&issue.title)).unwrap(),
sub_issues: issue
.sub_issues
.iter()
.map(|issue| (&**issue).into())
.collect(),
}
}
}
Expand Down
1 change: 0 additions & 1 deletion packages/next/src/build/swc/generated-native.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,6 @@ export interface NapiIssue {
detail?: any
source?: NapiIssueSource
documentationLink: string
subIssues: Array<NapiIssue>
}
export interface NapiIssueSource {
source: NapiSource
Expand Down
1 change: 0 additions & 1 deletion packages/next/src/build/swc/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export interface Issue {
}
}
documentationLink: string
subIssues: Issue[]
}

export interface Diagnostics {
Expand Down
19 changes: 0 additions & 19 deletions turbopack/crates/turbopack-core/src/issue/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,6 @@ pub trait Issue {
Vc::cell(None)
}

fn sub_issues(self: Vc<Self>) -> Vc<Issues> {
Vc::cell(Vec::new())
}

async fn into_plain(
self: Vc<Self>,
processing_path: Vc<OptionIssueProcessingPathItems>,
Expand Down Expand Up @@ -180,15 +176,6 @@ pub trait Issue {
None
}
},
sub_issues: self
.sub_issues()
.await?
.iter()
.map(|i| async move {
anyhow::Ok(i.into_plain(OptionIssueProcessingPathItems::none()).await?)
})
.try_join()
.await?,
processing_path: processing_path.into_plain().await?,
}
.cell())
Expand Down Expand Up @@ -691,7 +678,6 @@ pub struct PlainIssue {
pub documentation_link: RcStr,

pub source: Option<PlainIssueSource>,
pub sub_issues: Vec<ReadRef<PlainIssue>>,
pub processing_path: ReadRef<PlainIssueProcessingPath>,
}

Expand All @@ -714,11 +700,6 @@ fn hash_plain_issue(issue: &PlainIssue, hasher: &mut Xxh3Hash64Hasher, full: boo
}

if full {
hasher.write_value(issue.sub_issues.len());
for i in &issue.sub_issues {
hash_plain_issue(i, hasher, full);
}

hasher.write_ref(&issue.processing_path);
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::{collections::BTreeMap, fmt::Display, ops::Deref, path::PathBuf};
use std::{collections::BTreeMap, fmt::Display, path::PathBuf};

use serde::{Deserialize, Serialize};
use serde_json::Value;
Expand Down Expand Up @@ -146,7 +146,6 @@ pub struct Issue<'a> {
pub documentation_link: &'a str,

pub source: Option<IssueSource<'a>>,
pub sub_issues: Vec<Issue<'a>>,

pub formatted: String,
}
Expand All @@ -171,7 +170,6 @@ impl<'a> From<&'a PlainIssue> for Issue<'a> {
documentation_link: &plain.documentation_link,
detail: plain.detail.as_ref(),
source,
sub_issues: plain.sub_issues.iter().map(|p| p.deref().into()).collect(),
// TODO(WEB-691) formatting the issue should be handled by the error overlay.
// The browser could handle error formatting in a better way than the text only
// formatting here
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
warning - [analysis] [project]/turbopack/crates/turbopack-tests/tests/snapshot/export-alls/cjs-2/input/commonjs.js unexpected export *
export * used with module [project]/turbopack/crates/turbopack-tests/tests/snapshot/export-alls/cjs-2/input/commonjs.js [test] (ecmascript) which is a CommonJS module with exports only available at runtime
List all export names manually (`export { a, b, c } from "...") or rewrite the module to ESM, to avoid the additional runtime code.`

List all export names manually (`export { a, b, c } from "...") or rewrite the module to ESM, to avoid the additional runtime code.`
Loading