Skip to content

[dynamicIO] reimplement dynamicIO validation on prerender #79414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 0 additions & 155 deletions packages/next/src/server/app-render/app-render-prerender-utils.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { InvariantError } from '../../shared/lib/invariant-error'
import { isPrerenderInterruptedError } from './dynamic-rendering'

/**
* This is a utility function to make scheduling sequential tasks that run back to back easier.
Expand Down Expand Up @@ -32,95 +31,6 @@ export function prerenderAndAbortInSequentialTasks<R>(
}
}

export function prerenderServerWithPhases(
signal: AbortSignal,
render: () => ReadableStream<Uint8Array>,
finalPhase: () => void
): Promise<ServerPrerenderStreamResult>
export function prerenderServerWithPhases(
signal: AbortSignal,
render: () => ReadableStream<Uint8Array>,
secondPhase: () => void,
finalPhase: () => void
): Promise<ServerPrerenderStreamResult>
export function prerenderServerWithPhases(
signal: AbortSignal,
render: () => ReadableStream<Uint8Array>,
secondPhase: () => void,
thirdPhase: () => void,
...remainingPhases: Array<() => void>
): Promise<ServerPrerenderStreamResult>
export function prerenderServerWithPhases(
signal: AbortSignal,
render: () => ReadableStream<Uint8Array>,
...remainingPhases: Array<() => void>
): Promise<ServerPrerenderStreamResult> {
if (process.env.NEXT_RUNTIME === 'edge') {
throw new InvariantError(
'`prerenderAndAbortInSequentialTasks` should not be called in edge runtime.'
)
} else {
return new Promise((resolve, reject) => {
let result: ServerPrerenderStreamResult

signal.addEventListener(
'abort',
() => {
if (isPrerenderInterruptedError(signal.reason)) {
result.markInterrupted()
} else {
result.markComplete()
}
},
{
once: true,
}
)

setImmediate(() => {
try {
result = new ServerPrerenderStreamResult(render())
} catch (err) {
reject(err)
}
})

function runFinalTask(this: () => void) {
try {
if (result) {
result.markComplete()
this()
}
resolve(result)
} catch (err) {
reject(err)
}
}

function runNextTask(this: () => void) {
try {
if (result) {
result.markPhase()
this()
}
} catch (err) {
reject(err)
}
}

let i = 0
for (; i < remainingPhases.length - 1; i++) {
const phase = remainingPhases[i]
setImmediate(runNextTask.bind(phase))
}
if (remainingPhases[i]) {
const finalPhase = remainingPhases[i]
setImmediate(runFinalTask.bind(finalPhase))
}
})
}
}

const PENDING = 0
const COMPLETE = 1
const INTERRUPTED = 2
Expand Down Expand Up @@ -283,71 +193,6 @@ class PhasedStream<T> extends ReadableStream<T> {
}
}

export function prerenderClientWithPhases<T>(
render: () => Promise<T>,
finalPhase: () => void
): Promise<T>
export function prerenderClientWithPhases<T>(
render: () => Promise<T>,
secondPhase: () => void,
finalPhase: () => void
): Promise<T>
export function prerenderClientWithPhases<T>(
render: () => Promise<T>,
secondPhase: () => void,
thirdPhase: () => void,
...remainingPhases: Array<() => void>
): Promise<T>
export function prerenderClientWithPhases<T>(
render: () => Promise<T>,
...remainingPhases: Array<() => void>
): Promise<T> {
if (process.env.NEXT_RUNTIME === 'edge') {
throw new InvariantError(
'`prerenderAndAbortInSequentialTasks` should not be called in edge runtime.'
)
} else {
return new Promise((resolve, reject) => {
let pendingResult: Promise<T>
setImmediate(() => {
try {
pendingResult = render()
pendingResult.catch((err) => reject(err))
} catch (err) {
reject(err)
}
})

function runFinalTask(this: () => void) {
try {
this()
resolve(pendingResult)
} catch (err) {
reject(err)
}
}

function runNextTask(this: () => void) {
try {
this()
} catch (err) {
reject(err)
}
}

let i = 0
for (; i < remainingPhases.length - 1; i++) {
const phase = remainingPhases[i]
setImmediate(runNextTask.bind(phase))
}
if (remainingPhases[i]) {
const finalPhase = remainingPhases[i]
setImmediate(runFinalTask.bind(finalPhase))
}
})
}
}

// React's RSC prerender function will emit an incomplete flight stream when using `prerender`. If the connection
// closes then whatever hanging chunks exist will be errored. This is because prerender (an experimental feature)
// has not yet implemented a concept of resume. For now we will simulate a paused connection by wrapping the stream
Expand Down
Loading
Loading