Skip to content

chore: replace fs-extra usage in scripts/ #57215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Oct 22, 2023

The PR is the continuation of #56917 and #57030.

The PR replaces fs-extra#copy with Node.js built-in fs.cp API (which is almost identical to fs-extra#copy, and has been available since Node.js 16). The PR also provides a workaround for flaky Windows fs.rename operation (#57030).

cc @styfle @wbinnssmith

@SukkaW SukkaW requested a review from a team as a code owner October 22, 2023 15:34
@ijjk
Copy link
Member

ijjk commented Oct 22, 2023

Stats from current PR

Default Build
General
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
buildDuration 10.2s 10.4s ⚠️ +160ms
buildDurationCached 6s 6.6s ⚠️ +635ms
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 399ms 399ms
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
199-HASH.js gzip 29.2 kB 29.2 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 46.9 kB 46.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 504 B 506 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.3 kB 4.3 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.65 kB 2.65 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
_buildManifest.js gzip 486 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
index.html gzip 528 B 526 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 522 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
edge-ssr.js gzip 92.6 kB 92.6 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
middleware-b..fest.js gzip 625 B 626 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary SukkaW/next.js fs-extra-copy Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.2 kB 93.2 kB
app-page-tur..prod.js gzip 93.9 kB 93.9 kB
app-page-tur..prod.js gzip 88.5 kB 88.5 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 87.9 kB 87.9 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49 kB 49 kB
Overall change 923 kB 923 kB
Commit: 69c54d2

@SukkaW SukkaW marked this pull request as draft October 22, 2023 16:12
@SukkaW SukkaW marked this pull request as ready for review October 22, 2023 16:13
@ijjk
Copy link
Member

ijjk commented Nov 8, 2023

Tests Passed

@SukkaW
Copy link
Contributor Author

SukkaW commented Nov 9, 2023

Oh great. Now flaky test cases are stopping my PR from being merged. Let me update the branch again.

@kodiakhq kodiakhq bot merged commit 27dcd26 into vercel:canary Nov 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
@SukkaW SukkaW deleted the fs-extra-copy branch June 28, 2024 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants