Skip to content

Remove ServerDirectiveTransformer #56496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Remove ServerDirectiveTransformer #56496

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e49fd85
Remove ServerDirectiveTransformer
timneutkens Oct 5, 2023
e2fb266
Update another case
timneutkens Oct 5, 2023
abaecfb
Add missing import aliases
timneutkens Oct 5, 2023
a7f81a1
Merge branch 'canary' into 10-05-Remove_ServerDirectiveTransformer
kodiakhq[bot] Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/next-swc/crates/next-core/src/next_client/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ use turbopack_binding::{
},
dev::{react_refresh::assert_can_resolve_react_refresh, DevChunkingContext},
ecmascript::chunk::EcmascriptChunkingContext,
ecmascript_plugin::transform::directives::server::ServerDirectiveTransformer,
node::execution_context::ExecutionContext,
turbopack::{
condition::ContextCondition,
Expand Down Expand Up @@ -232,11 +231,6 @@ pub async fn get_client_module_options_context(
*get_emotion_transform_plugin(next_config).await?,
*get_styled_components_transform_plugin(next_config).await?,
*get_styled_jsx_transform_plugin().await?,
Some(Vc::cell(Box::new(ServerDirectiveTransformer::new(
// ServerDirective is not implemented yet and always reports an issue.
// We don't have to pass a valid transition name yet, but the API is prepared.
&Vc::cell("TODO".to_string()),
)) as _)),
]
.into_iter()
.flatten()
Expand Down