Skip to content

Use react-hot-loader/webpack #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Conversation

nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Dec 3, 2016

It seems this is required to detect unexported components according to the description of gaearon/react-hot-boilerplate#61.

@coveralls
Copy link

coveralls commented Dec 3, 2016

Coverage Status

Coverage remained the same at 37.259% when pulling ba522de on fix/react-hot-loader-setting into c5667a7 on master.

@matthewmueller
Copy link
Contributor

matthewmueller commented Dec 4, 2016

@nkzawa fwiw this dependency does make it harder for other types of renderers. See: #20 (comment)

@nkzawa
Copy link
Contributor Author

nkzawa commented Dec 5, 2016

@matthewmueller This is the correct setup of react-hot-loader anyway.
I think we should find a way to support other types of renderers even after we merged this.

@rauchg rauchg merged commit 9990a5f into master Dec 5, 2016
@rauchg rauchg deleted the fix/react-hot-loader-setting branch December 5, 2016 17:09
@rauchg
Copy link
Member

rauchg commented Dec 5, 2016

I think most likely the approach we'll take is that next-preact will be able to decorate the config and replace all the necessary babel and webpack modules.

@rauchg
Copy link
Member

rauchg commented Dec 5, 2016

And add the -compat webpack overrides, for example

@matthewmueller
Copy link
Contributor

matthewmueller commented Dec 5, 2016

@rauchg ahh yah, that sounds good. excited to see support for it – if you're not using other people's react UI modules, i'd say it's the best one out there.

@developit has a https://github.com/developit/preact-boilerplate with webpack config that should help. I've been messing around with combining next's and this one in some spare time.

Ideally it wouldn't even need the compat stuff, preact should be used standalone unless you're inheriting an existing react project.

@developit
Copy link
Contributor

Yup, should be able to work with this. Either we'll make preact+RHL play nicely or have next-preact replace it with something that does.

@kurtextrem
Copy link

What exactly is next-preact? I can't find it anywhere.

@developit
Copy link
Contributor

It was a proposed plugin that would inject the appropriate preact configs into next. Not necessary anymore though, instead there is a recipe here

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants