Update flags package json #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
AndyBitz
reviewed
Feb 11, 2025
| @@ -27,20 +27,20 @@ | |||
| "require": "./dist/index.cjs" | |||
| }, | |||
| "./next": { | |||
| "import": "./dist/next/index.js", | |||
| "require": "./dist/next/index.cjs" | |||
| "import": "./dist/next.js", | |||
There was a problem hiding this comment.
I think I've ran into issues when doing this in the past, either for exports or typesVersions, especially when importing this package.
Did you test it with a snapshot release?
There was a problem hiding this comment.
I've been iterating on the examples so far, but once they're passing, I'm looking to test a snapshot on an example ensuring it has legacy module resolution (moduleResolution: node)
AndyBitz
approved these changes
Feb 12, 2025
|
Tested using https://arethetypeswrong.github.io/ (
And on a preview deployment of our docs |
dferber90
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary changes:
tsup.config.jsentryto drop the/indexsuffix.Additional changes:
clean:truefor tsup to drop the rimraf dependencynode:imports as external instead of bundling them