All platforms: Update logo icons #1546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the old logo with a simplified one without extra label text. .ico and .icns are updated on Windows and macOS, and .png, .svg are added on Linux and FreeBSD. Original logo design by Andreas Becker, recreated by danielwerg with some edits and symbolic version by me.
|
Thank you @Jertzukka for taking care of this. Amazing work! I'm sorry for not being able to merge this before 1.26.24 release. |
|
@antonio-rojas @anthraxx I believe you are the archlinux package maintainers for veracrypt. Could you package next version with svg icon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the old logo with a simplified one without extra label text.
.ico and .icns are updated on Windows and macOS, and .png, .svg are added on Linux and FreeBSD. According to freedesktop Icon Theme Specification SVG icon is optional and not necessarily implemented, meaning that it alone isn't enough. The spec recommends PNGs in various sizes as the first choice, and XPM as the backup for backwards compatibility. Based on my testing, the DE often uses the exact size .png when available, and falls back to .svg for obscure sizes. When the theme requests symbolic version, we now also have that.
Removed the odd sizes for the old .xpm as these are not used anywhere in this project, nor by any of the distributors I checked, 256x256 is still available for backup use. Couldn't test on Windows as I couldn't get it to build, but I think src/Common/VeraCrypt.ico is the only location it is pulled from.
Original logo design by Andreas Becker, recreated by danielwerg with some edits and symbolic version added by me.
Fixes #1505