-
Notifications
You must be signed in to change notification settings - Fork 20
Add ppi argument #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ppi argument #86
Conversation
image-rs/image-png#403 was merged, so now we just need to wait for a release of Also, adding the pixel dimensions metadata broke the CLI test because they are still doing exact binary comparison. So we need to either regenerate the baseline images, or use DSSIM for approximate comparison like we do with the |
@joelostblom, development wheel are available for this PR at https://github.com/vega/vl-convert/actions/runs/5581857544 (just download and unzip the With these wheels, you can add a When you have a chance, let me know how this works for you! |
Thanks so much for the quick PR! This is working for me and I am able to adjust both the size and ppi of the charts independently after adding a |
Thanks for trying it out @joelostblom, glad it's working as expected! The PR in |
Just a heads up that I noticed that there was a new release made for |
Oh, awesome. I had missed that go by. I'll get this PR updated soon |
Closes #85, relies on image-rs/image-png#403 which was released in png 0.17.10.