Skip to content

fix(dnstap source): fix rcode 16 handling in dnsmsg-parser #23106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(dnstap source): fix rcode 16 handling in dnsmsg-parser #23106

wants to merge 3 commits into from

Conversation

esensar
Copy link
Contributor

@esensar esensar commented May 26, 2025

Summary

Changes RCODE 16 description to BADVERS instead of BADSIG, since BADSIG is used for TSIG RR (which is not parsed currently).

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

Sponsored by Quad9

@esensar
fix(dnstap source): fix rcode 16 handling in dnsmsg-parser
ab1ab1b 
Changes RCODE 16 description to BADVERS instead of BADSIG, since BADSIG is used for TSIG RR (which
is not parsed currently).

Related: https://www.iana.org/go/rfc6891
Related: https://www.iana.org/go/rfc8945
Closes: vectordotdev#22949
@esensar esensar requested review from a team as code owners May 26, 2025 09:30
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples approved these changes

Assignees
No one assigned
Labels
domain: external docs Anything related to Vector's external, public documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNSTap incorrect parsing of RCODE 16
2 participants
@esensar @joepeeples