Skip to content

feat(new source): okta #22968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(new source): okta #22968

wants to merge 6 commits into from

Conversation

sonnens
Copy link
Contributor

@sonnens sonnens commented Apr 30, 2025

Summary

Adds a new source to consume the Okta system log / audit log

Change Type

  • Bug fix
  • [ X ] New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • [ X ] No

How did you test this PR?

Tests are included in the PR, and I've run it on our own Okta instance

Does this PR include user facing changes?

  • [ X ] Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

References

@sonnens sonnens requested a review from a team as a code owner April 30, 2025 15:55
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Apr 30, 2025
@pront pront self-assigned this Apr 30, 2025
@sonnens
Copy link
Contributor Author

sonnens commented May 19, 2025

@pront anything needed on my end for this one?

@pront
Copy link
Member

pront commented May 19, 2025

@pront anything needed on my end for this one?

Hi @sonnens, and thank you for this PR! We want a few more docs files. You can look at other PRs for inspiration: https://github.com/vectordotdev/vector/pull/22609/files.

Note that make generate-component-docs will generate the files under base/ but the other CUE file needs to be handwritten.

@sonnens sonnens requested a review from a team as a code owner May 19, 2025 20:23
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label May 19, 2025
@sonnens
Copy link
Contributor Author

sonnens commented May 19, 2025

@pront something like this work?

hestonhoffman
hestonhoffman approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I left a couple small docs suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hestonhoffman hestonhoffman hestonhoffman approved these changes

Assignees

@pront pront

Labels
domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Okta system log source
3 participants
@sonnens @pront @hestonhoffman