Skip to content

enhancement(sinks): allow to provide aws session token #22964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anil-db
Copy link
Contributor

@anil-db anil-db commented Apr 30, 2025

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

when using aws access and secret keys sometime session token is also required if these access token is temporary.
mechanism of getting the temporary token and renew the token is external to vector. external system uses secret backend mechanism to let vector know the new set of tokens.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@anil-db anil-db requested review from a team as code owners April 30, 2025 00:08
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Apr 30, 2025
@anil-db anil-db changed the title enhancement(aws sinks): allow to provide aws session token enhancement(aws auth): allow to provide aws session token Apr 30, 2025
@pront pront self-assigned this Apr 30, 2025
@anil-db anil-db changed the title enhancement(aws auth): allow to provide aws session token enhancement(sinks): allow to provide aws session token Apr 30, 2025
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label May 12, 2025
@github-actions github-actions bot removed the domain: sinks Anything related to the Vector's sinks label May 12, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @anil-db

@pront pront enabled auto-merge May 12, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants