Skip to content

enhancement(greptimedb_logs sink): add headers field to greptimedb_logs config #22651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 24, 2025
Merged

enhancement(greptimedb_logs sink): add headers field to greptimedb_logs config #22651

merged 11 commits into from
Apr 24, 2025

Conversation

paomian
Copy link
Contributor

@paomian paomian commented Mar 13, 2025 •
edited
Loading

Summary

  • add http header config for greptimedb_logs sink

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: external docs Anything related to Vector's external, public documentation labels Mar 13, 2025
@paomian paomian marked this pull request as ready for review March 17, 2025 16:41
@paomian paomian requested review from a team as code owners March 17, 2025 16:41
@paomian paomian force-pushed the chore/greptimedb_header branch from aff1a8a to a181fc7 Compare March 17, 2025 16:48
pront
pront reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paomian

@pront pront self-assigned this Mar 24, 2025
@paomian paomian requested a review from pront March 26, 2025 05:06
@paomian
Copy link
Contributor Author

paomian commented Apr 1, 2025 •
edited
Loading

@pront Thanks to review. Is there anything else to improve about this pr?

pront
pront approved these changes Apr 2, 2025
View reviewed changes
@pront pront changed the title enhancement(greptiemdb_logs source): add config for greptimedb_logs to add http header enhancement(greptimedb_logs sink): add config for greptimedb_logs to add http header Apr 2, 2025
@pront pront changed the title enhancement(greptimedb_logs sink): add config for greptimedb_logs to add http header enhancement(greptimedb_logs sink): add headers field to greptimedb_logs config Apr 2, 2025
@pront
Copy link
Member

pront commented Apr 2, 2025

Apologies for the late review. Take a look at this failure please: https://github.com/vectordotdev/vector/actions/runs/14075914588/job/39856570713?pr=22651

@paomian paomian requested a review from pront April 3, 2025 05:50
@paomian
Copy link
Contributor Author

paomian commented Apr 8, 2025

@pront PTAL

@paomian
Copy link
Contributor Author

paomian commented Apr 14, 2025

The problem with changelog has been fixed. @pront PTAL

@pront pront requested a review from a team as a code owner April 14, 2025 15:19
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Apr 18, 2025
@paomian paomian changed the title enhancement(greptimedb_logs sink): add headers field to greptimedb_logs config breaking(greptimedb_logs sink): add headers field to greptimedb_logs config Apr 22, 2025
@paomian paomian changed the title breaking(greptimedb_logs sink): add headers field to greptimedb_logs config enhancement(greptimedb_logs sink): add headers field to greptimedb_logs config Apr 22, 2025
@paomian paomian requested a review from pront April 22, 2025 07:48
@pront pront enabled auto-merge April 24, 2025 17:19
@pront pront added this pull request to the merge queue Apr 24, 2025
Merged via the queue into vectordotdev:master with commit 1e7da76 Apr 24, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples approved these changes

@pront pront Awaiting requested review from pront

Assignees

@pront pront

Labels
domain: ci Anything related to Vector's CI environment domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paomian @pront @joepeeples